doc(IsFixedSearch): remove IsFixedSearch documentation #5666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request removes the Updated class diagram for Select componentclassDiagram
class Select {
+IsVirtualize: bool
-IsFixedSearch: bool
}
note for Select "IsVirtualize property added\nIsFixedSearch property removed"
Updated class diagram for MultiSelect componentclassDiagram
class MultiSelect {
+IsVirtualize: bool
}
note for MultiSelect "IsVirtualize property added"
Updated class diagram for SelectTree componentclassDiagram
class SelectTree {
-IsFixedSearch: bool
}
note for SelectTree "IsFixedSearch property removed"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The summary mentions styling adjustments, but it's unclear what problem the adjustments are trying to solve.
- It would be helpful to have a brief explanation of why
IsFixedSearchwas removed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5666 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 654
Lines 29542 29542
Branches 4204 4204
=========================================
Hits 29542 29542 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5665
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on the removal of theIsFixedSearchproperty and the addition of theIsVirtualizeproperty for various components. Additionally, there are updates to localization files and some styling adjustments.Removal of
IsFixedSearchProperty:src/BootstrapBlazor/Components/Filters/LookupFilter.razor: Removed theIsFixedSearchproperty fromSelectcomponents.src/BootstrapBlazor/Components/Select/SelectTree.razor: Removed theIsFixedSearchproperty from theTreeViewcomponent.test/UnitTest/Components/InternalTableColumnTest.cs: Removed theIsFixedSearchWhenSelectproperty from test cases.test/UnitTest/Components/TableTest.cs: Removed theIsFixedSearchWhenSelectproperty from test cases.Addition of
IsVirtualizeProperty:src/BootstrapBlazor.Server/Components/Samples/MultiSelects.razor.cs: Added theIsVirtualizeproperty toMultiSelect<string>.src/BootstrapBlazor.Server/Components/Samples/Selects.razor.cs: Added theIsVirtualizeproperty toSelect<string>.src/BootstrapBlazor.Server/Locales/en-US.json: Added localization forIsVirtualizeproperty in English.src/BootstrapBlazor.Server/Locales/zh-CN.json: Added localization forIsVirtualizeproperty in Chinese.Localization Updates:
src/BootstrapBlazor.Server/Locales/en-US.json: Removed entries forTreeViewFixedSearchTitleandTreeViewFixedSearchIntro.src/BootstrapBlazor.Server/Locales/zh-CN.json: Removed entries forTreeViewFixedSearchTitleandTreeViewFixedSearchIntro.Styling Adjustments:
src/BootstrapBlazor/Components/Select/Select.razor.scss: Adjusted.selectand.auto-completeclasses to include.clear-iconpositioning.src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss: Adjustedselect-search-iconpositioning.These changes aim to improve the functionality and user experience of the components by removing fixed search features and adding virtualization support, along with necessary updates to localization and styling.
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Removes the IsFixedSearch property from the Select and TreeView components, and adds the IsVirtualize property to the Select and MultiSelect components. Also includes localization and styling updates.
Enhancements: